Implement Default for SpinLock<SelfContainedContext>
#860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a bit silly since we cannot implement `Default` for `SpinLock<u64>` but clippy is complaining so throw it in.
tcharding
changed the title
Default for SpinLock<SelfContainedContext>Default for SpinLock<SelfContainedContext>
|
Also #858 has red CI that hopefully this fixes. I don't see the warning locally when I lint and I don't know why its showing up in CI now after merge. |
Draft
chain-forgexcr45
added a commit
to chain-forgexcr45/rust-secp256k1
that referenced
this pull request
Sep 28, 2025
…ock<SelfContainedContext>`
3216efd3c5ff97fba54ffaa09ac3ac38482336f5 Implement Default for SpinLock<SelfContainedContext> (Tobin C. Harding)
Pull request description:
This is a bit silly since we cannot implement `Default` for `SpinLock<u64>` but clippy is complaining so throw it in.
ACKs for top commit:
apoelstra:
ACK 3216efd3c5ff97fba54ffaa09ac3ac38482336f5; successfully ran local tests; sure
Tree-SHA512: e3786d80eaea60a4f547145fd76c77966fbbc68b7b111044e6db38f76ba1700baea6924a282b52cb86a16829489f119e279c0b4abaf145cb00bc8cc6b5ae5b11
william2332-limf
added a commit
to william2332-limf/rust-secp256k1
that referenced
this pull request
Oct 2, 2025
…ock<SelfContainedContext>`
3216efd3c5ff97fba54ffaa09ac3ac38482336f5 Implement Default for SpinLock<SelfContainedContext> (Tobin C. Harding)
Pull request description:
This is a bit silly since we cannot implement `Default` for `SpinLock<u64>` but clippy is complaining so throw it in.
ACKs for top commit:
apoelstra:
ACK 3216efd3c5ff97fba54ffaa09ac3ac38482336f5; successfully ran local tests; sure
Tree-SHA512: e3786d80eaea60a4f547145fd76c77966fbbc68b7b111044e6db38f76ba1700baea6924a282b52cb86a16829489f119e279c0b4abaf145cb00bc8cc6b5ae5b11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit silly since we cannot implement
DefaultforSpinLock<u64>but clippy is complaining so throw it in.