Fix missing docs #861
Merged
Fix missing docs #861
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Process fail, we cut the docs off on these two functions. Fix the docs using text taken directly from Poelstra's post on the issue. Close rust-bitcoin#847
|
ACK 1e06074; successfully ran local tests except for the flakey one |
chain-forgexcr45
added a commit
to chain-forgexcr45/rust-secp256k1
that referenced
this pull request
Sep 28, 2025
1e06074a85026b17c3913fcd64c50ff58d668f61 Fix missing docs (Tobin C. Harding)
Pull request description:
Process fail, we cut the docs off on these two functions.
Fix the docs using text taken directly from Poelstra's post on the issue.
Close #847
ACKs for top commit:
apoelstra:
ACK 1e06074a85026b17c3913fcd64c50ff58d668f61; successfully ran local tests except for the flakey one
Tree-SHA512: b8de71a73924e68022712432a2c3921f93a983e8f80496a6fa334fb5816b23b4bd6b6cdea551db2bb0062f60e305988c8c7d9b0b976a0392cf8234e63631b6bf
william2332-limf
added a commit
to william2332-limf/rust-secp256k1
that referenced
this pull request
Oct 2, 2025
1e06074a85026b17c3913fcd64c50ff58d668f61 Fix missing docs (Tobin C. Harding)
Pull request description:
Process fail, we cut the docs off on these two functions.
Fix the docs using text taken directly from Poelstra's post on the issue.
Close #847
ACKs for top commit:
apoelstra:
ACK 1e06074a85026b17c3913fcd64c50ff58d668f61; successfully ran local tests except for the flakey one
Tree-SHA512: b8de71a73924e68022712432a2c3921f93a983e8f80496a6fa334fb5816b23b4bd6b6cdea551db2bb0062f60e305988c8c7d9b0b976a0392cf8234e63631b6bf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Process fail, we cut the docs off on these two functions.
Fix the docs using text taken directly from Poelstra's post on the issue.
Close #847