Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port to rust-ini 0.16 #152

Merged
merged 1 commit into from
Mar 18, 2021
Merged

port to rust-ini 0.16 #152

merged 1 commit into from
Mar 18, 2021

Conversation

decathorpe
Copy link
Contributor

  • iterating over a loaded ini file sections / properties yields strs now, not Strings, so use to_owned(), not clone() to get an owned value from them
  • adapt one test for a small change in an expected error message

@matthiasbeyer
Copy link
Member

Where does this merge commit suddenly come from?

@decathorpe
Copy link
Contributor Author

I needed to resolve merge conflicts because rustfmt was run on the repo.

@matthiasbeyer
Copy link
Member

Would you please remove the commit from this branch?
This has nothing to do with the PR and just clutters up the history.

@decathorpe
Copy link
Contributor Author

You mean I should rebase my original change on the current master instead? Ok, I can do that ...

@decathorpe decathorpe changed the title port to rust-ini 0.15 port to rust-ini 0.16 Dec 9, 2020
@decathorpe
Copy link
Contributor Author

I rebased my changes and bumped to rust-ini 0.16 while I was at it. All INI related tests pass.
I encountered a few test failures that are not related to this change, I did not touch those.

@matthiasbeyer
Copy link
Member

Are you still interested in this?

If yes, I created a maintenance fork (read here).
If you want me to, I can include your patches there.

@decathorpe
Copy link
Contributor Author

Feel free to take my patch, but my interest in the config crate is no longer as big as it was when I submitted this PR.

@matthiasbeyer
Copy link
Member

This is merged in config-rs-maint as of master a3f205dc628b59a32de813b3efefbaec4667d217.

@matthiasbeyer
Copy link
Member

Hey, would you please rebase this to latest master?

@matthiasbeyer matthiasbeyer merged commit 65acce6 into rust-cli:master Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants