Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A public ValueKind allows external Source implementations #164

Closed
wants to merge 1 commit into from
Closed

A public ValueKind allows external Source implementations #164

wants to merge 1 commit into from

Conversation

brosander
Copy link

No description provided.

@fpoli fpoli mentioned this pull request Feb 1, 2021
Closed
@fpoli
Copy link

fpoli commented Feb 1, 2021

Are you sure ValueKind needs to be public? See here for an example of how to implement a Source in a different crate.

@brosander
Copy link
Author

Good call, I'd been going off the env implementation but it's not necessary

https://github.com/mehcode/config-rs/blob/master/src/env.rs#L114

@brosander brosander closed this Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brosander @fpoli