Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am of the (personal) opinion that the timestamp format used in
env_logger
is too noisy. So for my personal purposes I rewrote some of the timestamp formatting code to allow for different formats. This is a attempt to share some of that code back to upstream.Briefly,
humantime
tochrono
, this is to allow for more variance in formats (humantime
only supports RFC3339, whereaschrono
supports that and more (including custom format strings).I'm reasonably new to contributing to open-source Rust projects so I would appreciate a bit of guidance as I know my code is definitely not perfect :P.
EDIT: Obviously, I can do superficial things like adding examples/ unit tests. Just would like some guidance overall first though.
Sorry, I didn't read the contributing guidelines until after I made my commits. Don't know what you want me to do about that.