Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about dashes #77

Merged
merged 1 commit into from
Apr 8, 2018
Merged

Add note about dashes #77

merged 1 commit into from
Apr 8, 2018

Conversation

lnicola
Copy link
Contributor

@lnicola lnicola commented Apr 6, 2018

No description provided.

Copy link
Collaborator

@KodrAus KodrAus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah this is a good point! Thanks @lnicola!

This happens because what we print after the timestamp is the Rust module path to the log message. So it uses the crate name that you would use with extern crate which is always an underscore, instead of the crate name that you set in your Cargo.toml which can have dashes.

@lnicola
Copy link
Contributor Author

lnicola commented Apr 7, 2018

@KodrAus Yup, I figured out the reason, but this took me a while to figure because the logs were working on one computer and not on another. The difference was the target (I assume release builds show less), but it was still confusing 😄.

Do you think the explanation should be mentioned in the docs?

@lnicola
Copy link
Contributor Author

lnicola commented Apr 7, 2018

I added a note and changed "dashes" to "hyphens".

@KodrAus
Copy link
Collaborator

KodrAus commented Apr 8, 2018

Thanks @lnicola! I'll merge this in.

@KodrAus KodrAus merged commit f7af715 into rust-cli:master Apr 8, 2018
@lnicola lnicola deleted the dash-warning branch April 8, 2018 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants