Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback to repository if homepage is absent #77

Open
Yamakaky opened this issue Aug 20, 2021 · 2 comments · May be fixed by #78
Open

Fallback to repository if homepage is absent #77

Yamakaky opened this issue Aug 20, 2021 · 2 comments · May be fixed by #78
Labels
breaking-change enhancement Improve the expected

Comments

@Yamakaky
Copy link

Choose one: is this a 🙋 feature request

Expected Behavior

When the Cargo.toml parameter repository is present and homepage is absent, no URL is included in the message. If one wants to add the github URL, they need to set it in homepage. It's a bad practice since homepage is for a real home page, not a repository.

Current Behavior

repository is ignored.

Possible Solution

It would be nice to have a fallback to repository if homepage is absent. Or better, print both since they add different useful information.

Context

Code Sample

Your Environment

Software Version(s)
Package
Runtime
Package Manager
Operating System
Michael-F-Bryan added a commit to Michael-F-Bryan/human-panic that referenced this issue Sep 26, 2021
Michael-F-Bryan added a commit to Michael-F-Bryan/human-panic that referenced this issue Sep 26, 2021
@epage epage added enhancement Improve the expected breaking-change labels Feb 1, 2023
@musselmandev
Copy link

@epage is there a reason this has not been merged? I came here to inquire about this as well...
Thank you for this awesome crate!

@epage
Copy link
Collaborator

epage commented Nov 15, 2024

Likely at the time, it was a breaking change and we were unready for it. Now, the PR has been stale for years.

I am open to homepage falling back to repository. I don't think we should show both, at least not with more information as to why. If someone is interested in that, they should create an issue specifically about the problem where showing both would be a solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change enhancement Improve the expected
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants