Ensure macro-internal variables are properly encapsulated #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks! |
Collaborator
|
Released in v1.1.5 |
dead-claudia
added a commit
to dead-claudia/human-panic
that referenced
this pull request
Jun 13, 2023
The other tests only needed modified to fix a column number. This should help prevent regressions down this front. I've verified they also failed prior to that patch.
dead-claudia
added a commit
to dead-claudia/human-panic
that referenced
this pull request
Jun 13, 2023
The other tests only needed modified to fix a column number. This should help prevent regressions down this front. I've verified they also failed prior to that patch.
dead-claudia
added a commit
to dead-claudia/human-panic
that referenced
this pull request
Jun 13, 2023
The other tests only needed modified to fix a column number. The action was mysteriously only running one of the tests - I've fixed that. This should help prevent regressions for rust-cli#109 and possibly others. I've verified they also failed prior to that patch.
dead-claudia
added a commit
to dead-claudia/human-panic
that referenced
this pull request
Jun 13, 2023
The other tests only needed modified to fix a column number. The action was mysteriously only running one of the tests - I've fixed that. This should help prevent regressions for rust-cli#109 and possibly others. I've verified they also failed prior to that patch.
dead-claudia
added a commit
to dead-claudia/human-panic
that referenced
this pull request
Jun 13, 2023
The other tests only needed modified to fix a column number. The action was mysteriously only running one of the tests - I've fixed that. This should help prevent regressions for rust-cli#109 and possibly others. I've verified they also failed prior to that patch.
dead-claudia
added a commit
to dead-claudia/human-panic
that referenced
this pull request
Jun 13, 2023
The other tests only needed modified to fix a column number. The action was mysteriously only running one of the tests - I've fixed that. This should help prevent regressions for rust-cli#109 and possibly others. I've verified they also failed prior to that patch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I actually ran into this in the wild with a local
Metadatastruct that wasn't being referenced correctly in the outer function, resulting in pretty obvious compilation errors.