feat: Add support section
#133
Conversation
|
cc @epage |
tisonkun
force-pushed
the
add-supports-links
branch
3 times, most recently
from
2ec81f6
to
f773eb4
Compare
tisonkun
force-pushed
the
add-supports-links
branch
from
f773eb4
to
624b886
Compare
Signed-off-by: tison <wander4096@gmail.com>
tisonkun
force-pushed
the
add-supports-links
branch
from
624b886
to
e487206
Compare
src/lib.rs
Outdated
| @@ -64,6 +64,8 @@ pub struct Metadata { | |||
| pub authors: Cow<'static, str>, | |||
| /// The URL of the crate's website | |||
| pub homepage: Cow<'static, str>, | |||
| /// The support information | |||
| pub supports: Cow<'static, str>, | |||
There was a problem hiding this comment.
I feel like this should be support rather than supports, both in code and in the UI
src/lib.rs
Outdated
| @@ -64,6 +64,8 @@ pub struct Metadata { | |||
| pub authors: Cow<'static, str>, | |||
| /// The URL of the crate's website | |||
| pub homepage: Cow<'static, str>, | |||
| /// The support information | |||
| pub supports: Cow<'static, str>, | |||
There was a problem hiding this comment.
We should probably be using Option<_> rather than using an empty string as a sentinel
There was a problem hiding this comment.
(yes, we check for empty strings in other cases but those are meant to be populated by metadata! and likely we shouldn't even be doing that...)
|
Thanks for moving this forward! |
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
tisonkun
force-pushed
the
add-supports-links
branch
from
7f89425
to
f28307b
Compare
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
|
Anyway push a solution. Please feel free to drop more comments. |
|
I've just merged a PR for updating the CI and another PR for making the API more resilient to change. |
|
@epage Then I suppose you can pick up this PR onto your edits? Close as conflict now. |
|
I can redo it, but you go further on this way already now. I don't care the credit but get the changes done. I suppose you can go faster than me. |
This refers to #54