Revise title-generation function #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit revises the title-generation function to accept a Vec of Strings. This allows it to accept other arguments that are passed to .TH (such as the date and version). It also removes the capitalization, in part because not all of these arguments are capitalized and in part because that degree of semantic formatting (titles need to be capitalized) seems more appropriate for a higher level crate like `man`.
|
This was addressed in #15 |
epage
added a commit
that referenced
this pull request
Oct 6, 2023
README.md list indentation and no bare URLs, as per Markdown Lint VS Code extension
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR revises the title-generation function to accept a Vec of Strings. This allows it to accept other arguments that are passed to .TH (such as the date and version). As disscussed in #6, this would be useful to any users of roff-rs that want to configure the date or version for a man page (including
man).It also removes the capitalization, in part because not all of these arguments are capitalized and in part because that degree of semantic formatting (titles need to be capitalized) seems more appropriate for a higher level crate like
man.