Adds support for reading/writing to save media. #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Alright i'll assign this to myself so that i can hopefully see it in the list and i'll more likely get back to it, but we'll resolve the other PR first. |
|
Is this also complete now that #107 is? |
|
Same as 108, it is ready, assuming it looks good on review. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new API for reading and writing to save media. It supports all types of media officially used in Nintendo Game Paks, although I've only tested it so far on emulators and not real hardware. (I'll have the equipment to do that soon!)
The new
test_savegameexample is an example of how to use it, and also a test to make sure everything is supported well.Note that the PR depends on #107. The save module uses quite a bit of global state, and that PR implements the types I've used to implement that state.