Setting up WASM logging in diplomat-runtime
#346
Conversation
tool/src/js/wasm.mjs
Outdated
| @@ -5,13 +5,22 @@ let wasm; | |||
|
|
|||
| const imports = { | |||
| env: { | |||
| log_js(ptr, len) { | |||
| console_debug_js(ptr, len) { | |||
There was a problem hiding this comment.
this is a bit of a breaking change, no?
might be ok since we don't have users of the JS backend
There was a problem hiding this comment.
It depends how diplomat-runtime is versioned wrt diplomat-tool. I'm changing both sides of the FFI here, so it should not be breaking.
There was a problem hiding this comment.
Yeah the problem is someone using icu4x would get an automatic update of diplomat-runtime. This may be an acceptable thing to break for now since JS is still very iffy (cc @sffc?) and the logging isn't proprely hooked up.
Also can we scope it as diplomat_console_...?
There was a problem hiding this comment.
Yeah this is breaking, but releasing major diplomat versions is not a lot of work.
There was a problem hiding this comment.
I'd rather fix JS than go out of our way to make it backwards compatible with clients I don't think we have right now.
No description provided.