Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dart: contiguous enums #357

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Dart: contiguous enums #357

merged 1 commit into from
Nov 7, 2023

Conversation

robertbastian
Copy link
Collaborator

@robertbastian robertbastian commented Nov 7, 2023 •
edited
Loading

Part of #439

Manishearth
Manishearth approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@Manishearth Manishearth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems fine though this might be cleaned up further by unconditionally generating a toFFI()/fromFFI() and calling it everywhere else

@robertbastian
Copy link
Collaborator Author

The asFfi/fromFfi expressions are quite short, and sometimes unused so I think inlining them is better.

@robertbastian robertbastian merged commit 5f3cdc6 into main Nov 7, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manishearth Manishearth Manishearth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robertbastian @Manishearth