Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dart: prefix stripping #358

Merged
merged 2 commits into from
Nov 7, 2023
Merged

Dart: prefix stripping #358

merged 2 commits into from
Nov 7, 2023

Conversation

robertbastian
Copy link
Collaborator

@robertbastian robertbastian commented Nov 7, 2023

Also enabling renaming and disabling

Part of #439

pub fn new(
tcx: &'tcx TypeContext,
docs_url_generator: &'tcx DocsUrlGenerator,
strip_prefix: Option<String>,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this so that we can strip the ICU4X prefix? I guess that works

The way I want to support this is to do it the other way; we add prefixes in the C code and everyone else uses namespaces for this if they want to.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But this does involve tweaking the existing backends; which is annoying. Ideally I'd like to abandon the AST backends soon so that we can start moving to the right architecture for stuff like this.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The way I want to support this is to do it the other way; we add prefixes in the C code and everyone else uses namespaces for this if they want to.

Yeah same. That does require adding annotations on the diplomat-bridge level, which is more complex at the moment.

@robertbastian robertbastian merged commit 0d9e2b7 into main Nov 7, 2023
5 checks passed
@Manishearth Manishearth deleted the dart branch November 7, 2023 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants