Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dart: Rune type #364

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Dart: Rune type #364

merged 1 commit into from
Nov 21, 2023

Conversation

robertbastian
Copy link
Collaborator

@robertbastian robertbastian commented Nov 21, 2023

Dart doesn't have a character/unicode code point type, although it does use the "code point" or "rune" concept on some methods of String. This adds a typedef Rune = int to generated Dart code to provide some documentation and make the API more understandable.

Note to self: check what happens if an invalid char makes it to Rust, as that's UB.

@dcharkes

Part of #439

@robertbastian robertbastian merged commit b604325 into main Nov 21, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants