Adding str support back
#369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
approved these changes
Nov 27, 2023
| Type::Slice(hir::Slice::Str(_, hir::StringEncoding::UnvalidatedUtf8)) => { | ||
| Type::Slice(hir::Slice::Str( | ||
| _, | ||
| hir::StringEncoding::UnvalidatedUtf8 | hir::StringEncoding::Utf8, |
There was a problem hiding this comment.
nit: we should emit docs, yes?
There was a problem hiding this comment.
or are we relying on cpp2's lack of docs? if so we should have an issue filed for that and note that str validity should be added
There was a problem hiding this comment.
I was assuming we'll continue using the current cpp docs for cpp2?
There was a problem hiding this comment.
No, cpp2 has a different structure.
Manishearth
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Diplomat will generate C++ docs that say invalid UTF-8 is UB. However, this is not inline documentation, so I'm not super happy with this.
#57