Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typedef in result #394

Merged
merged 2 commits into from
Dec 19, 2023
Merged

Fix typedef in result #394

merged 2 commits into from
Dec 19, 2023

Conversation

robertbastian
Copy link
Collaborator

@robertbastian robertbastian commented Dec 19, 2023 •
edited
Loading

Fixes #393

Including the .h instead of defining a typedef correctly puts the typedef into the capi namespace in C++.

Manishearth
Manishearth approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@Manishearth Manishearth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we did this to avoid cyclic imports when methods need imports. But if this works, this works!

@robertbastian
Copy link
Collaborator Author

The gen task is broken on main, looks like we cannot use /tmp anymore. Merging.

@robertbastian robertbastian merged commit 4bb7d03 into main Dec 19, 2023
5 of 6 checks passed
@robertbastian robertbastian deleted the include branch December 19, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manishearth Manishearth Manishearth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typedef in .h shadows class in .hpp
2 participants
@robertbastian @Manishearth