Fix initialization in immutable structs in Dart #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was an oversight from rust-diplomat#408: previously when we lazy-loaded structs, converting a struct back to FFI could be a no-op if the struct wasn't mutable. However in the new eager-converted structs, structs always need to be converted back.
robertbastian
approved these changes
Jan 31, 2024
Comment on lines
+800
to
+802
| // Note: {dart_name} == null ? 0 : {dart_name}.underlying | ||
| // will not work for struct fields since Dart can't guarantee the | ||
| // null check will be unchanged between the two accesses. |
There was a problem hiding this comment.
been in Rust so long that it took me a minute to realise what you mean here :)
There was a problem hiding this comment.
it is kinda cool that Dart has refinement types here, I like refinement types
but it's annoying when you hit their limitations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was an oversight from #408: previously when we lazy-loaded structs, converting a struct back to FFI could be a no-op if the struct wasn't mutable.
However in the new eager-converted structs, structs always need to be converted back.
Part of #439