Correct lifetimes for borrowing of dart slice *parameters* #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // and also ensure it's not destroyed. | ||
| format!("{param_name}View") | ||
| // Slices make an arena with a finalizer that needs to be attached | ||
| format!("{param_name}Arena") |
There was a problem hiding this comment.
If we are doing one arena per parameter we might as well do the same as in JS where we attach finalizers that free using diplomat_free
There was a problem hiding this comment.
What's the difference? Both allocate in the native heap, yes?
Also it's one arena per parameter that gets borrowed in the output. It's going to be rare.
I don't think it's a good idea to have two separate paths for slice construction based on arenas or native rust allocation: the way this is designed all slices need for conversion is an arena, it can be a temporary one or a finalized one.
robertbastian
approved these changes
Feb 22, 2024
Manishearth
force-pushed
the
dart-borrow-slice
branch
from
041b0c8
to
519fc2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress on #421, using approach from #406 (comment)
This does not yet handle slices in structs, but it's relatively self contained so I figured I'd make an early PR.
Part of #439