fix js str decode #727
Merged
fix js str decode #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcrist1
commented
Nov 8, 2024
| @@ -1,18 +1,23 @@ | |||
| import test from 'ava'; | |||
There was a problem hiding this comment.
my editor reformatted some stuff. I hope this is okay.
jcrist1
commented
Nov 8, 2024
| @@ -257,7 +257,7 @@ impl<'jsctx, 'tcx> TyGenContext<'jsctx, 'tcx> { | |||
| // We basically iterate through and read each string into the array. | |||
| // TODO: Need a test for this. | |||
| format!( | |||
| r#"new diplomatRuntime.DiplomatSliceStrings(wasm, {variable_name}, "string{}", {edges})"#, | |||
| r#"new diplomatRuntime.DiplomatSliceStrings(wasm, {variable_name}, "string{}", {edges}).getValue()"#, | |||
There was a problem hiding this comment.
As far as i could see there isn't actually a DiplomatSliceStrings in the runtime, but I thought consistency would be a good guide
Manishearth
approved these changes
Nov 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I uncovered another bug in the js backend, while I was working on a library using diplomat.
The bug is that methods returning string slices return
DiplomatStrSliceclass instead of a jsstring. It's the same issue that affected #722 , and the fix is the same.