Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ip_in_core #81

Merged
merged 1 commit into from
Apr 22, 2023

Conversation

newAM
Copy link
Contributor

@newAM newAM commented Apr 22, 2023

No description provided.

Copy link
Member

@ryan-summers ryan-summers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor request on dependencies. However, I'm not sure how meaningful this PR will be until the changes land in stable, since library authors will implement the e-nal, and end users won't have the ability to pick and choose. As such, it seems like optional features are actually bad? Not sure though, what's the e-nal approach?

embedded-nal-async/Cargo.toml Show resolved Hide resolved
@newAM
Copy link
Contributor Author

newAM commented Apr 22, 2023

However, I'm not sure how meaningful this PR will be until the changes land in stable, since library authors will implement the e-nal, and end users won't have the ability to pick and choose.

Crate authors can provide a pass-through to select this feature. Not a great solution, but at the same time if nobody uses ip_in_core then it likely wont get stabilized.

@ryan-summers
Copy link
Member

Welp, let's try it out and see how it works! :)

@ryan-summers ryan-summers merged commit cb280e5 into rust-embedded-community:master Apr 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants