Add a NOR trait to encode that word clearing is supported #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to encode MCU flashes that have ECC, where it is common that only a complete clear of the word is allowed. This is a more restrictive version of `MultiwriteNorFlash` as it cannot encode flashes with ECC support.
korken89
force-pushed
the
add-wordclear-nor
branch
from
a742ef4 to
14c7cb2
Compare
|
While obvious to add the trait like this, I'm not sure this is the best way to do it... In Sequential-Storage I'd like to be able to switch behaviour depending on whether a true multiwrite can be done, or only a clear to 0. I'm not sure on how to do this. However, say we change the MultiWriteNorFlash trait to have an associated const bool that declares the ability, then we could make a meaningful selection so it can use the pessimistic algo for clear-only. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to encode MCU flashes that have ECC, where it is common that only a complete clear of the word is allowed. This is a more restrictive version of
MultiwriteNorFlashas it cannot encode flashes with ECC support.Example use-case of this trait: tweedegolf/sequential-storage#63