Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate to embedded-hal=1.0.0.rc1 #25

Merged
merged 3 commits into from
Nov 28, 2023
Merged

migrate to embedded-hal=1.0.0.rc1 #25

merged 3 commits into from
Nov 28, 2023

Commits on Nov 25, 2023

  1. update to embedded-hal-mock = "0.10.0-rc.2"

    also ensure that `done()` is called on all mocks (otherwise the tests
    now fail). this also unearthed 1-2 bugs where the expectations were
    wrong.
    
    since e-h-m 0.10.0 requires rust 1.63 the MSRV for this crate has been
    raised accordingly as we now cannot test on older releases anymore. it
    might still work there however.
    rursprung committed Nov 25, 2023
    Configuration menu
    Copy the full SHA
    a152edb View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2023

  1. migrate to embedded-hal=1.0.0.rc1

    as alpha.10 of embedded-hal has added `SetDutyCycle` as the equivalent /
    successor of the old `PwmPin` support for it can now be added here.
    
    since e-h 1.0.0 will be released at the end of this year it's safe to
    just directly migrate to the RC1 instead of adding it as an optional
    support (requiring another breaking change in a later step which would
    then remove e-h 0.2 support).
    rursprung committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    2011c21 View commit details
    Browse the repository at this point in the history
  2. change forbid for warnings & unused to deny

    a new warning was caused by the `?` operator as it contains
    `#[allow(unreachable_code)]`, which clashes with the previous `forbid`
    rule.
    
    as `forbid` does not allow `deny` to override it this would cause a
    compile error, however due to a compiler bug this was previously not
    reported at all and has now been changed to a warning in a recent(-ish)
    version of rustc and will eventually become a compile error.
    
    with `deny` it's still possible to use `allow`, thus there's no warning
    
    see also rust-lang/rust#76053
    
    thanks @jannic
    rursprung committed Nov 28, 2023
    Configuration menu
    Copy the full SHA
    204de95 View commit details
    Browse the repository at this point in the history