Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating poll functions to return results #147

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Updating poll functions to return results #147

wants to merge 1 commit into from

Conversation

ryan-summers
Copy link
Member

This PR updates the traits to allow poll() to return Result<> types if needed. I'm unsure if the UsbClass::poll() function should return a Result or not currently.

@sourcebox
Copy link
Contributor

I think this PR makes sense because currently there's no way to return an error from the driver. Using PollResult::None in such situations is ambiguous.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryan-summers @sourcebox