Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CriticalSection<'cs> instead of &'cs CriticalSection. #20

Merged
merged 1 commit into from
Jan 28, 2020

Conversation

m-ou-se
Copy link
Contributor

@m-ou-se m-ou-se commented Oct 30, 2019

Fixes #7.

A CriticalSection<'cs> has a size of zero
unlike a &'cs CriticalSection, which has the size of a pointer.

Fixes rust-embedded#7.

A `CriticalSection<'cs>` has a size of zero
unlike a `&'cs CriticalSection`, which has the size of a pointer.
@jonas-schievink jonas-schievink mentioned this pull request Jan 9, 2020
7 tasks
@therealprof
Copy link
Contributor

bors ping

@jonas-schievink
Copy link
Contributor

bors r+

bors bot added a commit that referenced this pull request Jan 28, 2020
20: Use CriticalSection<'cs> instead of &'cs CriticalSection. r=jonas-schievink a=m-ou-se

Fixes #7.

A `CriticalSection<'cs>` has a size of zero
unlike a `&'cs CriticalSection`, which has the size of a pointer.

Co-authored-by: Mara Bos <m-ou.se@m-ou.se>
@bors
Copy link
Contributor

bors bot commented Jan 28, 2020

Build succeeded

@bors bors bot merged commit 23156b0 into rust-embedded:master Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inefficiency in the CriticalSection API
3 participants