Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small text changes #174

Merged
merged 1 commit into from
Mar 3, 2019
Merged

Small text changes #174

merged 1 commit into from
Mar 3, 2019

Conversation

Niederb
Copy link
Contributor

@Niederb Niederb commented Mar 3, 2019

Some small changes I did while reading.
Feel fee to incorporate what you like and discard the rest.

@Niederb Niederb requested a review from a team as a code owner March 3, 2019 14:37
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @andre-richter (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-resources labels Mar 3, 2019
Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@therealprof
Copy link
Contributor

bors r+

bors bot added a commit that referenced this pull request Mar 3, 2019
174: Small text changes r=therealprof a=Niederb

Some small changes I did while reading.
Feel fee to incorporate what you like and discard the rest.

Co-authored-by: Thomas Niederberger <thomas@niederb.ch>
@bors
Copy link
Contributor

bors bot commented Mar 3, 2019

Build succeeded

@bors bors bot merged commit 133f4f0 into rust-embedded:master Mar 3, 2019
bors added a commit to rust-lang/rust that referenced this pull request Mar 5, 2019
Update books

Update nomicon, reference, book, edition-guide, embedded-book

rust-by-example cannot be updated because it is currently broken (rust-lang/rust-by-example#1161)

## nomicon

8 commits in b7eb4a087207af2405c0669fa577f8545b894c66..f1ff93b66844493a7b03101c7df66ac958c62418
2018-11-30 08:52:24 -0500 to 2019-02-26 13:37:28 -0500
- Fix typo in other-reprs.md (rust-lang/nomicon#112)
- Remove duplicate 'the' in aliasing.md (rust-lang/nomicon#116)
- Fix typo in subtyping.md (rust-lang/nomicon#117)
- Trivial updates to the coercions chapter (rust-lang/nomicon#118)
- Fix double "the" in aliasing.md (rust-lang/nomicon#119)
- Fixes outdated bindgen link (rust-lang/nomicon#110)
- Fix link to type layout reference (rust-lang/nomicon#121)
- Fix capitalization of Rust in races.md (rust-lang/nomicon#107)

## reference

18 commits in 1c775a1..41493ff
2019-01-13 21:12:05 +0100 to 2019-03-05 12:32:22 +0100
- Fix broken link. (rust-lang/reference#527)
- Update attribute documentation. (rust-lang/reference#528)
- Remove target_has_atomic. (rust-lang/reference#529)
- Remove "mode" from derive macro terminology. (rust-lang/reference#530)
- Clarifications (rust-lang/reference#493)
- Fix an incorrect note (rust-lang/reference#522)
- Document extern_crate_self (rust-lang/reference#517)
- Fix spelling (rust-lang/reference#520)
- Update conditional-compilation.md (rust-lang/reference#503)
- Document if_while_or_patterns (rust-lang/reference#516)
- Fix some broken links. (rust-lang/reference#519)
- Clarify what access struct updates do (rust-lang/reference#518)
- Document irrefutable_let_patterns (rust-lang/reference#515)
- Document Rc/Arc method receivers. (rust-lang/reference#494)
- unions have no active field (rust-lang/reference#478)
- attributes.md Outer -> Inner (rust-lang/reference#510)
- Let bindings are now available in const contexts (rust-lang/reference#512)
- Add missed literal at MacroFragSpec (rust-lang/reference#513)

## book

2 commits in fab9419503f0e34c1a06f9350a6705d0ce741dc6..9cffbeabec3bcec42d09432bfe7705125c848889
2019-02-25 07:53:23 -0500 to 2019-03-02 08:22:41 -0500
- More edits (rust-lang/book#1838)
- Remove the 2018 edition nostarch directory

## edition-guide

1 commits in 5f3cc2a5618700efcde3bc00799744f21fa9ad2e..aa0022c875907886cae8f3ef8e9ebf6e2a5e728d
2019-02-27 20:11:50 -0800 to 2019-02-27 22:10:39 -0800
- Fix one last link in readme. (rust-lang/edition-guide#153)

## embedded-book

12 commits in bd2778f304989ee52be8201504d6ec621dd60ca9..9e656ead82bfe869493dec82653a52e27fa6a05c
2019-02-10 12:37:14 +0000 to 2019-03-03 16:03:26 +0000
- Merge rust-embedded/book#174
- Merge rust-embedded/book#172
- Merge rust-embedded/book#169
- Merge rust-embedded/book#171
- Merge rust-embedded/book#168
- Merge rust-embedded/book#153
- Merge rust-embedded/book#142 rust-embedded/book#151
- Merge rust-embedded/book#133 rust-embedded/book#135
- Merge rust-embedded/book#150
- Merge rust-embedded/book#145
- Merge rust-embedded/book#129
- Merge rust-embedded/book#128
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-resources
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants