Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add CNAME #24

Merged
merged 1 commit into from
Sep 14, 2018
Merged

add CNAME #24

merged 1 commit into from
Sep 14, 2018

Conversation

japaric
Copy link
Member

@japaric japaric commented Sep 13, 2018

https://book.rust-embedded.org/ and https://rust-embedded.github.io/book/ are
not displaying the same contents. I believe that's because this file was
missing.

r? @rust-embedded/resources (anyone)
cc @nastevens

@japaric japaric requested a review from a team as a code owner September 13, 2018 18:51
Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird, but I see no harm in adding this, so LGTM.

@therealprof
Copy link
Contributor

bors r+

bors bot added a commit that referenced this pull request Sep 14, 2018
24: add CNAME r=therealprof a=japaric

https://book.rust-embedded.org/ and https://rust-embedded.github.io/book/ are
not displaying the same contents. I believe that's because this file was
missing.

r? @rust-embedded/resources (anyone)
cc @nastevens

Co-authored-by: Jorge Aparicio <jorge@japaric.io>
@bors
Copy link
Contributor

bors bot commented Sep 14, 2018

Build succeeded

@bors bors bot merged commit 7309d24 into master Sep 14, 2018
@bors bors bot deleted the cname branch September 14, 2018 05:16
njmartin10 pushed a commit to njmartin10/book that referenced this pull request Nov 10, 2018
24: add CNAME r=therealprof a=japaric

https://book.rust-embedded.org/ and https://rust-embedded.github.io/book/ are
not displaying the same contents. I believe that's because this file was
missing.

r? @rust-embedded/resources (anyone)
cc @nastevens

Co-authored-by: Jorge Aparicio <jorge@japaric.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants