Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't print compiler messages when --quiet is passed #91

Merged
merged 1 commit into from
Sep 6, 2020
Merged

Don't print compiler messages when --quiet is passed #91

merged 1 commit into from
Sep 6, 2020

Conversation

toothbrush7777777
Copy link
Contributor

No description provided.

@toothbrush7777777 toothbrush7777777 requested a review from a team as a code owner September 6, 2020 18:18
@rust-highfive
Copy link

r? @Emilgardis

(rust_highfive has picked a reviewer for you, use r? to override)

@toothbrush7777777
Copy link
Contributor Author

toothbrush7777777 commented Sep 6, 2020 •
edited
Loading

The CI error has nothing to do with this pull request. It appears that -arch-name has been renamed to --arch-name in LLVM 11.

@therealprof
Copy link
Contributor

The CI error has nothing to do with this pull request. It appears that -arch-name has been renamed to --arch-name in LLVM 11.

Meh. :(

@therealprof
Copy link
Contributor

Seems like double hyphen style long options also work before LLVM 11 and they've deprecated the single hyphen ones in LLVM 11.

I've created #92 to change that, let's see whether CI agrees...

therealprof
therealprof approved these changes Sep 6, 2020
View reviewed changes
Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

bors r+

@bors
Copy link
Contributor

bors bot commented Sep 6, 2020

Build succeeded:

@bors bors bot merged commit 52ee51d into rust-embedded:master Sep 6, 2020
@toothbrush7777777 toothbrush7777777 deleted the patch-1 branch September 6, 2020 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@therealprof therealprof therealprof approved these changes

Assignees

@Emilgardis Emilgardis

Labels
S-waiting-on-review T-tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@toothbrush7777777 @rust-highfive @therealprof @Emilgardis