Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider getting rid of aligned dependency subtree #184

Closed
nickray opened this issue Jan 8, 2020 · 4 comments · Fixed by #190
Closed

Consider getting rid of aligned dependency subtree #184

nickray opened this issue Jan 8, 2020 · 4 comments · Fixed by #190
Milestone

Comments

@nickray
Copy link

nickray commented Jan 8, 2020

This eventually pulls in two versions of generic-array which is a bit weird. Maybe take over aligned and/or as-slice and add some feature flags there? Or make itm::write_aligned itself an optional feature?

re. #183

@jonas-schievink
Copy link
Contributor

Oh this is where all the generic-array dependencies come from? I was wondering about that.

Pulling in 4 dependencies for a single function seems very excessive, so I'm on board with removing them. We can add our own alignment-enforcing struct to the itm module instead.

@nickray
Copy link
Author

nickray commented Jan 14, 2020

Yeah for some (compatibility?) reason as-slice pulls in both.

@therealprof
Copy link
Contributor

Yeah, otherwise you run into weird compatibility problems.

@nickray
Copy link
Author

nickray commented Jan 14, 2020

(Offtopic. None of my dependencies that depend on generic-array use 0.12, so I' be curious what compatibility issues there might be? Is it really not an "alter Zopf"? :) )

@bors bors bot closed this as completed in #190 Jan 15, 2020
@bors bors bot closed this as completed in 465c64d Jan 15, 2020
adamgreig pushed a commit that referenced this issue Jan 12, 2022
184: 0.6.8 release r=therealprof a=korken89



Co-authored-by: Emil Fresk <emil.fresk@gmail.com>
Co-authored-by: Daniel Egger <daniel@eggers-club.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants