Use u8 repr for enum instead of custom method #203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an alternative proposal to #202 as suggested in #202 (comment) Signed-off-by: Daniel Egger <daniel@eggers-club.de>
|
r? @korken89 (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
S-waiting-on-review
|
Not sure, that's what I want to find to (and also whether this compiles with the MSRV), but it certainly is at least an improvement for |
|
This is a 1.0 feature, so the only concern is codegen. I do believe rustc will attach LLVM range metadata, so it should optimize well. |
|
Well, it did build, even with the current MSRV. And it definitely is an improvement in codegen for dev builds at least and most certainly no regression for release builds. 😉 |
Build succeeded |
adamgreig
pushed a commit
that referenced
this pull request
Jan 12, 2022
203: Update to Syn 1.0 r=korken89 a=dtolnay Release notes: https://github.com/dtolnay/syn/releases/tag/1.0.0 Co-authored-by: David Tolnay <dtolnay@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative proposal to #202 as suggested in
#202 (comment)
Signed-off-by: Daniel Egger daniel@eggers-club.de