Add new InterruptNumber trait #241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @korken89 (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
S-waiting-on-review
|
I like it! I'm also a big fan of the |
jonas-schievink
previously approved these changes
Jul 9, 2020
|
I've updated to fix the failing CI (due to the use of some |
therealprof
added
the
nominated
|
As discussed in todays meeting this should be adjusted to lose the |
adamgreig
force-pushed
the
interrupt-number
branch
from
00467cd to
b5ad45c
Compare
jonas-schievink
previously approved these changes
Jul 21, 2020
therealprof
requested changes
Jul 21, 2020
therealprof
approved these changes
Jul 22, 2020
|
Build succeeded: |
therealprof
removed
the
nominated
adamgreig
pushed a commit
that referenced
this pull request
Jan 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first go at the new trait needed for rust-embedded/svd2rust#455 since we removed
Nrfrom bare-metal.In this case I've written it as
unsafe trait InterruptNumber: Into<u16>rather than providing a conversion method inside the trait; I think this is neat and idiomatic but please correct me if there's a reason to not do it like this.Here's a playground link showing an example implementation.