Skip to content

Prepare 0.6.4 #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 26, 2020
Merged

Prepare 0.6.4 #275

merged 1 commit into from
Oct 26, 2020

Conversation

adamgreig
Copy link
Member

Includes #274 to fix recent issues with inline-asm on nightly.

@adamgreig adamgreig requested a review from a team as a code owner October 26, 2020 10:36
@rust-highfive
Copy link

r? @jonas-schievink

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against v0.6.x. Please double check that you specified the right target!

@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-cortex-m labels Oct 26, 2020
jonas-schievink
jonas-schievink approved these changes Oct 26, 2020
View reviewed changes
Copy link
Contributor

@jonas-schievink jonas-schievink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot added a commit that referenced this pull request Oct 26, 2020
@bors @adamgreig
Merge #275
2aabb4c 
275: Prepare 0.6.4 r=jonas-schievink a=adamgreig

Includes #274 to fix recent issues with inline-asm on nightly.

Co-authored-by: Adam Greig <adam@adamgreig.com>
@bors
Copy link
Contributor

bors bot commented Oct 26, 2020

Timed out.

@adamgreig
Copy link
Member Author

bors retry

bors bot added a commit that referenced this pull request Oct 26, 2020
@bors @adamgreig
Merge #275
c3f641b 
275: Prepare 0.6.4 r=jonas-schievink a=adamgreig

Includes #274 to fix recent issues with inline-asm on nightly.

Co-authored-by: Adam Greig <adam@adamgreig.com>
@bors
Copy link
Contributor

bors bot commented Oct 26, 2020

Timed out.

@adamgreig
Copy link
Member Author

Looks like Travis is just being slow triggering some builds. If this one doesn't take I'll try again tonight or something.

bors retry

bors bot added a commit that referenced this pull request Oct 26, 2020
@bors @adamgreig
Merge #275
630010a 
275: Prepare 0.6.4 r=jonas-schievink a=adamgreig

Includes #274 to fix recent issues with inline-asm on nightly.

Co-authored-by: Adam Greig <adam@adamgreig.com>
@bors
Copy link
Contributor

bors bot commented Oct 26, 2020

Timed out.

@adamgreig
Copy link
Member Author

bors retry

bors bot added a commit that referenced this pull request Oct 26, 2020
@bors @adamgreig
Merge #275
d3a7c2a 
275: Prepare 0.6.4 r=jonas-schievink a=adamgreig

Includes #274 to fix recent issues with inline-asm on nightly.

Co-authored-by: Adam Greig <adam@adamgreig.com>
@bors
Copy link
Contributor

bors bot commented Oct 26, 2020

Timed out.

@therealprof therealprof merged commit 30d9d19 into v0.6.x Oct 26, 2020
@bors bors bot deleted the v0.6.4 branch October 26, 2020 23:05
@adamgreig
Copy link
Member Author

Released!

adamgreig added a commit that referenced this pull request Jan 12, 2022
@bors @adamgreig
Merge #276
fbcfff1 
276: Replace __ONCE__ with Cargo links key r=jonas-schievink a=adamgreig

This would fix #275. We use the links key in cortex-m already [here](https://github.com/rust-embedded/cortex-m/blob/master/Cargo.toml#L16). See also rust-embedded/wg#467.

Co-authored-by: Adam Greig <adam@adamgreig.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonas-schievink jonas-schievink jonas-schievink approved these changes

Assignees

@jonas-schievink jonas-schievink

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-cortex-m
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adamgreig @rust-highfive @jonas-schievink @therealprof