Skip to content

Conversation

adamgreig
Copy link
Member

No description provided.

@adamgreig adamgreig requested a review from a team as a code owner August 11, 2022 23:02
@rust-highfive
Copy link

r? @thalesfragoso

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against v0.7.x. Please double check that you specified the right target!

@adamgreig
Copy link
Member Author

bors r=newAM

@bors
Copy link
Contributor

bors bot commented Aug 13, 2022

Build succeeded:

@bors bors bot merged commit 641e419 into v0.7.x Aug 13, 2022
@bors bors bot deleted the v0.7.6 branch August 13, 2022 17:27
bors bot added a commit to embassy-rs/embassy that referenced this pull request Aug 17, 2022
901: Update to critical-section 1.0, atomic-polyfill 1.0 r=Dirbaio a=Dirbaio

TODO
- [x] Wait for cortex-m 0.7.6 release rust-embedded/cortex-m#449
- [x] ~~Wait for defmt-rtt 0.4 release knurling-rs/defmt#689 we're still going to use defmt 0.3 for now, which will use the `critical-section` 0.2 default impl, which works.
- [x] Wait for critical-secton `std` impl rust-embedded/critical-section#22

Co-authored-by: Dario Nieuwenhuis <dirbaio@dirbaio.net>
bors bot added a commit to rust-embedded/embedded-alloc that referenced this pull request Dec 8, 2022
56: Use critical-section for heap locking, rename to `embedded-alloc`. r=adamgreig a=Dirbaio

This uses `critical_section::with` instead of `cortex_m::interrupt::free` to acquire a critical section. This allows customizing the critical section implementation, to make it sound for multicore chips for example.

This is a breaking change, so it'll require a 0.5 release.

Interestingly this makes the crate not cortex-m specific anymore. Perhaps it could be renamed to something more general?

TODO
- [x] Wait for cortex-m 0.7.6 release rust-embedded/cortex-m#449

Co-authored-by: Dario Nieuwenhuis <dirbaio@dirbaio.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-cortex-m
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants