cortex-m-rt: fix off-by-one in .text in FLASH section assert #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original assertion states that is checking that .text is inside flash, but it also precludes .text being at the start of flash.
This shouldn't affect anyone using the linker script from within cortex-m-rt as the vector table is always at the start. Only folks using this script as a template for a custom linker script would notice this issue.
Background:
I was using this linker script as a template for writing a run-from-ram binary for rp2040.
The way the rp2040 tools identify a run-from-ram binary is that the entry point is the first thing in the binary.
So I moved the vector table back, and the Entry function to the start, and then hit this assertion.