Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture trait requires moving/copying channel argument #249

Open
hannobraun opened this issue Oct 1, 2020 · 0 comments
Open

Capture trait requires moving/copying channel argument #249

hannobraun opened this issue Oct 1, 2020 · 0 comments

Comments

@hannobraun
Copy link
Member

I think this doesn't make any sense, as it either requires Clone/Copy implementations for the channel type (which might be undesirable, as it limits the HAL design). I believe the methods should take shared or mutable references, as appropriate.

Also see #244 and and #246, which are about the same problem, but regarding the PWM trait.

@ryankurte ryankurte added this to the v1.0.0 milestone Oct 2, 2020
@eldruin eldruin removed this from the v1.0.0 milestone Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants