-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document SemVer hazards of spi::Operation::DelayNs
#552
Milestone
Comments
Closed
Dirbaio
added a commit
to Dirbaio/embedded-hal
that referenced
this issue
Dec 27, 2023
Dirbaio
added a commit
to Dirbaio/embedded-hal
that referenced
this issue
Dec 27, 2023
opened #558 to address this. It picks solution 2, which is sort of what we agreed on when we added the "no delay" versions: it's theoretically semver-breaking but in practice it's going to be rare that a driver starts using delays if it wasn't before. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Imagine this timeline:
SpiDevice
but doesn't useDelayNs
.SpiDevice
impl from embedded_hal_bus withNoDelay
. The user tests it and it works fine.DelayNs
and releases it as cool-driver 1.0.1Aside from making actual changes to the
SpiDevice
trait, I can only think of two possible "solutions":DelayNs
they have made a breaking change and they must release it as version 2.0.0 instead.NoDelay
, but if they do they must pin the version of any dependency that they use it with.I don't really like either of these options, but I don't have any better ideas.
The text was updated successfully, but these errors were encountered: