Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PwmPin: allow get_duty to return the old value for some time #236

Merged
merged 1 commit into from
Jul 22, 2020
Merged

PwmPin: allow get_duty to return the old value for some time #236

merged 1 commit into from
Jul 22, 2020

Conversation

eldruin
Copy link
Member

@eldruin eldruin commented Jul 21, 2020 •
edited
Loading

This is #140 rebased to master.
However, I suppose the same thing applies to the Pwm::try_get_duty() method. Shouldn't the same note be added to that method as well?

Closes #140

@chrysn @eldruin
PwmPin: allow get_duty to return the old value for some time
d26ccb9 
PWM is often implemented in a buffered way to allow glitch-free
operation; as a result, implementing a strict "you get what you last
set" is not feasible for some implementations.
@eldruin eldruin requested review from ilya-epifanov and a team as code owners July 21, 2020 17:08
@rust-highfive
Copy link

r? @ryankurte

(rust_highfive has picked a reviewer for you, use r? to override)

therealprof
therealprof approved these changes Jul 22, 2020
View reviewed changes
Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

bors r+

@therealprof
Copy link
Contributor

However, I suppose the same thing applies to the Pwm::try_get_duty() method. Shouldn't the same note be added to that method as well?

Sure, why not. The more documentation the better. ;)

@bors
Copy link
Contributor

bors bot commented Jul 22, 2020

Build succeeded:

@bors bors bot merged commit 5b898bb into rust-embedded:master Jul 22, 2020
@eldruin eldruin mentioned this pull request Jul 22, 2020
Merged
bors bot added a commit that referenced this pull request Jul 22, 2020
@bors @eldruin
Merge #238
d81cf7c 
238:  Pwm: allow get_duty to return the old value for some time r=therealprof a=eldruin

This is #140 applied to the `Pwm` trait as well, since the same concerns apply. Follows up on #236.

Co-authored-by: Diego Barrios Romero <eldruin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@therealprof therealprof therealprof approved these changes

@ilya-epifanov ilya-epifanov Awaiting requested review from ilya-epifanov

Assignees

@ryankurte ryankurte

Labels
S-waiting-on-review Review is incomplete T-hal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@eldruin @rust-highfive @therealprof @ryankurte @chrysn