Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

u8 as default SPI Word #321

Merged
merged 2 commits into from
Nov 4, 2021
Merged

u8 as default SPI Word #321

merged 2 commits into from
Nov 4, 2021

Conversation

burrbull
Copy link
Member

@burrbull burrbull commented Nov 3, 2021

Part of #320

@burrbull burrbull requested a review from a team as a code owner November 3, 2021 10:17
@rust-highfive
Copy link

r? @ryankurte

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added S-waiting-on-review Review is incomplete T-hal labels Nov 3, 2021
Sh3Rm4n
Sh3Rm4n reviewed Nov 3, 2021
View reviewed changes
Copy link
Contributor

@Sh3Rm4n Sh3Rm4n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a sensible default and may also be expanded to other traits, like the Serial traits?

Dirbaio
Dirbaio approved these changes Nov 3, 2021
View reviewed changes
Copy link
Member

@Dirbaio Dirbaio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this! I can't think of any downside, and the vast majority of SPI uses are u8.

We should do the same for uart and other traits.

ryankurte
ryankurte approved these changes Nov 3, 2021
View reviewed changes
Copy link
Contributor

@ryankurte ryankurte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems reasonable to me, any other opinions @rust-embedded/hal ?

@therealprof
Copy link
Contributor

LGTM!

eldruin
eldruin approved these changes Nov 4, 2021
View reviewed changes
Copy link
Member

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as well, thank you!
bors r+

@bors
Copy link
Contributor

bors bot commented Nov 4, 2021

Build succeeded:

@bors bors bot merged commit ac66e33 into rust-embedded:master Nov 4, 2021
@eldruin eldruin mentioned this pull request Feb 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sh3Rm4n Sh3Rm4n Sh3Rm4n left review comments

@eldruin eldruin eldruin approved these changes

@ryankurte ryankurte ryankurte approved these changes

@Dirbaio Dirbaio Dirbaio approved these changes

Assignees

@ryankurte ryankurte

Labels
S-waiting-on-review Review is incomplete T-hal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@burrbull @rust-highfive @therealprof @eldruin @ryankurte @Dirbaio @Sh3Rm4n