i2c: enforce all traits have the same Error type. #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @therealprof (rust-highfive has picked a reviewer for you, use r? to override) |
Dirbaio
force-pushed
the
i2c-unify-error
branch
from
dd68891 to
bd6a047
Compare
eldruin
previously approved these changes
Dec 20, 2021
Dirbaio
force-pushed
the
i2c-unify-error
branch
from
bd6a047 to
8bad7f5
Compare
eldruin
previously approved these changes
Dec 20, 2021
Dirbaio
force-pushed
the
i2c-unify-error
branch
from
8bad7f5 to
7e59a5e
Compare
Merged
|
Friendly ping @eldruin @therealprof @ryankurte are there any pending concerns on this? |
bors bot
added a commit
that referenced
this pull request
Jan 18, 2022
339: I2c unify r=eldruin a=Dirbaio Depends on #336 Equivalent of #323 but for I2c. I think for i2c unifying everything in a single trait makes the most sense. The i2c bus is specified to be bidirectional, I believe no hardware out there can "only write" or "only read" (and writing requires *reading* ACK bits anyway!). Co-authored-by: Dario Nieuwenhuis <dirbaio@dirbaio.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Equivalent of #331 for i2c.