Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove IoPin #393

Merged
merged 1 commit into from
Aug 9, 2022
Merged

Remove IoPin #393

merged 1 commit into from
Aug 9, 2022

Conversation

Dirbaio
Copy link
Member

@Dirbaio Dirbaio commented Jul 26, 2022

As discussed in #340 it's unclear if the current IoPin trait is the best way to go (tldr: due to the fact it changes type it's hard to own it in driver structs).

I propose temporarily removing it, to unblock the 1.0 release. When discussion settles on a final design, we can add it back.

@rust-highfive
Copy link

r? @therealprof

(rust-highfive has picked a reviewer for you, use r? to override)

@Dirbaio Dirbaio marked this pull request as ready for review July 26, 2022 13:08
@Dirbaio Dirbaio requested a review from a team as a code owner July 26, 2022 13:08
Copy link
Member

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Seems reasonable, though unfortunate, to me in light of #340.
Especially the argument about pins being dropped for good.

TODO if merged:

  • Add tracking issue

Further thoughts @rust-embedded/hal?

@Dirbaio Dirbaio added this to the v1.0.0 milestone Aug 2, 2022
Copy link
Member

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, this seems uncontroversial both here and in our weekly meetings. Thank you!
bors r+

@bors bors bot merged commit d5cdf33 into rust-embedded:master Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Review is incomplete T-hal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants