Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

async/serial: add Write. #442

Merged
merged 1 commit into from
Mar 14, 2023
Merged

async/serial: add Write. #442

merged 1 commit into from
Mar 14, 2023

Conversation

Dirbaio
Copy link
Member

@Dirbaio Dirbaio commented Mar 7, 2023

Extracted out of #349

This is just Write, mirroring the blocking version. so it should hopefully be uncontroversial.

@Dirbaio Dirbaio requested a review from a team as a code owner March 7, 2023 23:35
@Dirbaio Dirbaio mentioned this pull request Mar 8, 2023
Closed
eldruin
eldruin approved these changes Mar 14, 2023
View reviewed changes
Copy link
Member

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!
bors r+

@Dirbaio
Copy link
Member Author

Dirbaio commented Mar 14, 2023

bors r+

seems bors is lazy today?

@bors
Copy link
Contributor

bors bot commented Mar 14, 2023

Build succeeded:

@bors bors bot merged commit 1533716 into rust-embedded:master Mar 14, 2023
eldruin added a commit to eldruin/embedded-hal that referenced this pull request Mar 15, 2023
@eldruin
Update changelog after rust-embedded#442
65e4bfa
eldruin added a commit to eldruin/embedded-hal that referenced this pull request Mar 15, 2023
@eldruin
Update changelog after rust-embedded#442
336eb5a
@eldruin eldruin mentioned this pull request Mar 15, 2023
Merged
bors bot added a commit that referenced this pull request Mar 15, 2023
@bors @eldruin
Merge #446
3250073 
446: Update changelog after #442 r=Dirbaio a=eldruin

This was forgotten in #442 

Co-authored-by: Diego Barrios Romero <eldruin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eldruin eldruin eldruin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dirbaio @eldruin