-
Notifications
You must be signed in to change notification settings - Fork 246
CAN: raw ID getter function #669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
What is your use case for this? This has come up before (#428). As described in the linked PR I’m not a big fan of the proposed API as it makes mixing Standard and Extended IDs easy, something that usually is not intended. |
I just wanted to retrieve the raw ID for quick debugging/printing purposes (after I could not simpy print it with defmt). I did not care about the Standard ID / Extended ID distinction in that case, and I found it weird/unintuitive that I had to unmatch the value. After going through the mentioned thread for a bit, I can see the point of intentionally making the mixup harder. |
What about a |
Have you enabled |
The latest main has defmt support, but not 0.4.1. A new release for embedded-can is required |
@timokroeger I updated the PR |
047043d
to
9c72048
Compare
Looks reasonable to me but pinging @rust-embedded/hal for review |
9c72048
to
bd66331
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
No description provided.