-
Notifications
You must be signed in to change notification settings - Fork 245
Release embedded-io 0.7 #679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release embedded-io 0.7 #679
Conversation
I think this is ready for review; having been announced on the Tuesday WG meeting is probably as much exposure for any more "let's get that in"s as this gets before doing an actual release. |
In my opinion, #648 should be resolved before releasing v0.7 |
Those are additions to a non_exhaustive enum, and thus not breaking, and can happen in any release.
I'm happy to continue the discussion there, as to avoid undue delay, but from the perspective of crates that need to converge onto an 1.0 that 0.7 should be semver compatible with, I'd rather have 0.7 yesterday, and a 0.7.1 once #648 is solved.
|
As a preparation for the (hopefully) upcoming release. Looking forward to rust-embedded#679.
I don't think there's anything other than someone from the team saying "Yes" missing. (I can rebase this any time, but there's probably no point to that until there's confirmation, given there should be a date to include). |
Ping @rust-embedded/hal |
The following PRs would be very useful to us:
Just to make sure they don't go unnoticed. :) |
#696 is about the async counterpart that isn't going for a last-call-before 1.0 (and is unaffected by the embedded-io release). Reading the issue, I think what async does now is better (and maybe we should provide #697 is not breaking, so it could go into a 0.7.1 as well – nonetheless, looking into it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
59c4771
to
af58563
Compare
Thanks. Date is adjusted to today, hope this holds until the button is pressed :-) |
Ping @rust-embedded/hal again. Only thing that's missing here is someone changing the release date in the Changelog, approving+merging this PR, and doing the |
af58563
to
305d5cd
Compare
We should do the release at the same time for -io and -io-async, otherwise async users are left without being able to use it. EDIT: and -io-adapters too. This means merging #696 first. |
I don't think that embedded-io-async is on the same stabilization path as embedded-io yet – fortunately it probably needs to be (for if embedded-io 0.7 becomes 1.0 compatibly, there can still be an embedded-io-async that depends on -io 1.0 for where it's needed). Doing those releases together does certainly make things easier in terms of dependency management. I'll put this on hold briefly until #696 is through, and then update this PR to be a simultaneous release (including changelog) of all three crates. |
305d5cd
to
c2727ea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
can you add the changelog for #697?
|
Contributes-To: rust-embedded#566
c2727ea
to
9123afb
Compare
Done. Conveniently, this also updates the MSRV of async to 1.81, which would otherwise not be achievable due to the embedded-io dependency anyway. |
Contributes-To: #566
This is a Draft PR until