Skip to content

fix CI #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 13, 2019
Merged

fix CI #47

merged 1 commit into from
Apr 13, 2019

Conversation

japaric
Copy link
Member

@japaric japaric commented Apr 8, 2019

llvm-objdump recently changed its output format; this commit fixes our objdump
tests

@japaric
fix CI
2359967 
llvm-objdump recently changed its output format; this commit fixes our objdump
tests
@japaric japaric requested a review from a team as a code owner April 8, 2019 21:18
@rust-highfive
Copy link

r? @korken89

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-resources labels Apr 8, 2019
korken89
korken89 approved these changes Apr 9, 2019
View reviewed changes
Copy link
Contributor

@korken89 korken89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@korken89
Copy link
Contributor

korken89 commented Apr 9, 2019

bors r+

bors bot added a commit that referenced this pull request Apr 9, 2019
@bors @japaric
Merge #47
2c5137c 
47: fix CI r=korken89 a=japaric

llvm-objdump recently changed its output format; this commit fixes our objdump
tests

Co-authored-by: Jorge Aparicio <jorge@japaric.io>
@bors
Copy link
Contributor

bors bot commented Apr 9, 2019

Build failed

@japaric
Copy link
Member Author

japaric commented Apr 9, 2019

Right, I forgot to test the stable channel locally. A new stable release should be out in two days so we can just retry this in a few days and it should land.

@mathk mathk added S-waiting-on-bors and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 10, 2019
@japaric
Copy link
Member Author

japaric commented Apr 13, 2019

This should work now that 1.34 has been released.

bors retry

bors bot added a commit that referenced this pull request Apr 13, 2019
@bors @japaric
Merge #47
b079ec7 
47: fix CI r=korken89 a=japaric

llvm-objdump recently changed its output format; this commit fixes our objdump
tests

Co-authored-by: Jorge Aparicio <jorge@japaric.io>
@bors
Copy link
Contributor

bors bot commented Apr 13, 2019

Build succeeded

@bors bors bot merged commit 2359967 into master Apr 13, 2019
@bors bors bot deleted the fix-ci branch April 13, 2019 15:17
@japaric japaric mentioned this pull request Apr 13, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@korken89 korken89 korken89 approved these changes

Assignees

@korken89 korken89

Labels
S-waiting-on-bors T-resources
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@japaric @rust-highfive @korken89 @mathk