Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notes about creating a custom target #67

Merged
merged 11 commits into from
Jul 6, 2020

Conversation

lights0123
Copy link
Contributor

As we were discussing rust-lang/rust#58500, I realized that there is nowhere other than community blogs that actually discusses how to create a new target. This adds new documentation about creating custom targets and common pitfalls that you may encounter.

@lights0123 lights0123 requested a review from a team as a code owner June 18, 2020 15:24
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jamesmunns (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-resources labels Jun 18, 2020
@lights0123
Copy link
Contributor Author

This also supersedes #42, as I wrote about eh_personality without looking at existing PRs.

@lights0123
Copy link
Contributor Author

@jamesmunns any chance to get this reviewed?

Comment on lines +11 to +12
Many targets already have a known triple used to describe them, typically in the form
ARCH-VENDOR-SYS-ABI. You should aim to use the same triple that [LLVM uses][llvm-target-triple];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uhm, ARCH-VENDOR-SYS-ABI is a quadruple(t), not a triple(t). ;)

Co-authored-by: Daniel Egger <daniel@eggers-club.de>
Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A clear improvement! Thanks a lot.

bors r+

@bors
Copy link
Contributor

bors bot commented Jul 6, 2020

Build succeeded:

@bors bors bot merged commit 4d10be2 into rust-embedded:master Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-resources
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants