-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add notes about creating a custom target #67
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jamesmunns (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
This also supersedes #42, as I wrote about eh_personality without looking at existing PRs. |
@jamesmunns any chance to get this reviewed? |
Many targets already have a known triple used to describe them, typically in the form | ||
ARCH-VENDOR-SYS-ABI. You should aim to use the same triple that [LLVM uses][llvm-target-triple]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uhm, ARCH-VENDOR-SYS-ABI is a quadruple(t), not a triple(t). ;)
Co-authored-by: Daniel Egger <daniel@eggers-club.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A clear improvement! Thanks a lot.
bors r+
Build succeeded: |
As we were discussing rust-lang/rust#58500, I realized that there is nowhere other than community blogs that actually discusses how to create a new target. This adds new documentation about creating custom targets and common pitfalls that you may encounter.