unconditionally depend on atomic-polyfill for riscv32i target #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
May 12, 2022
293: unconditionally depend on atomic-polyfill for riscv32i target r=japaric a=japaric due to a limitation in the llvm backend [1] the `riscv32i-unknown-none-elf` target lacks the `core::sync::atomic` API even though the actual hardware is capable of atomic loads and stores (`fence` instruction). thus, at this point in time, this target needs `atomic-polyfill` for a working SPSC implementation [1]: knurling-rs/defmt#597 (comment) fixes #271 closes #272 closes #273 Co-authored-by: Jorge Aparicio <jorge.aparicio@ferrous-systems.com>
|
Build failed: |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
May 12, 2022
293: unconditionally depend on atomic-polyfill for riscv32i target r=japaric a=japaric due to a limitation in the llvm backend [1] the `riscv32i-unknown-none-elf` target lacks the `core::sync::atomic` API even though the actual hardware is capable of atomic loads and stores (`fence` instruction). thus, at this point in time, this target needs `atomic-polyfill` for a working SPSC implementation [1]: knurling-rs/defmt#597 (comment) fixes #271 closes #272 closes #273 Co-authored-by: Jorge Aparicio <jorge.aparicio@ferrous-systems.com>
|
Canceled. |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
due to a limitation in the llvm backend 1 the
riscv32i-unknown-none-elftarget lacks thecore::sync::atomicAPI even though the actual hardware is capable of atomic loads and stores (fenceinstruction). thus, at this point in time, this target needsatomic-polyfillfor a working SPSC implementationfixes #271
closes #272
closes #273