Adapt to embedded-hal-1.0.0-alpha.1

[eldruin]

I adapted this to the embedded-hal-1.0.0-alpha.1 release.
As part of it I also replaced void with core::convert::Infallible.

(blocked on rust-embedded/embedded-hal#177)

[rust-highfive]

r? @ryankurte

(rust_highfive has picked a reviewer for you, use r? to override)

[reneherrero]

Curious as to what's holding this back?

Reason I'm asking is I'm trying to submit a PR to add Controller Area Network (CAN) support. The changes in this PR would help me do so as I'm referencing another PR that implements the CAN traits and is a fork off embedded-hal 1.0.0-alpha.1.

If something is preventing these changes from going to master, would it perhaps be possible to push them to another branch?

Thanks

[ryankurte]

hey, this is unlikely to land until the upstream embedded-hal release so we can keep applying changes if required to the current release. you should be able to pull eldruin's changes into your branch with something like: git pull https://github.com/eldruin/linux-embedded-hal.git embedded-hal-1.0.0-alpha.1 so your PR depends on this one if this would work for you?

[reneherrero]

Yeah, I did contemplate that thought, was just hesitant to go that route as my PR would include another PR's changes which seemed a little bit funky as you would have the same changes in two places.

I figured that if you where good with the changes here, you might prefer having a v1.0.0 branch here, ie have a vNext branch and allow folks to PR into that and keep master for any hot fixes that might come up.

Multiple ways to skin the cat, it's your house, I'll go whichever route you like

[ryankurte]

hey @posborne how would you feel about doing a maintenance / alpha split like we have with e-h?
(branch for backporting fixes / changes to previous releases, pull master up to a new alpha release?)

[posborne]

hey @posborne how would you feel about doing a maintenance / alpha split like we have with e-h?
(branch for backporting fixes / changes to previous releases, pull master up to a new alpha release?)

@ryankurte That seems reasonable to me.