Add github actions CI #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @posborne (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
S-waiting-on-review
|
bors try |
tryBuild succeeded: |
|
rustfmt seems to have failed. Could you fix that @ryankurte? |
|
huh, looks like actions is now executing and i'm not sure what changed? applied rustfmt, fingers crossed... |
eldruin
previously approved these changes
Feb 1, 2021
bors bot
added a commit
that referenced
this pull request
Feb 1, 2021
57: Add github actions CI r=eldruin a=ryankurte Replaces #56, just adding the actions executor without swapping bors or removing travis. Odds are this doesn't work but, seemingly one can't add actions to a repo from a branch so it has to be manually merged anyway and fixed in PRs... @posborne seem (un)reasonable? Co-authored-by: ryan <ryan@kurte.nz>
|
Timed out. |
|
bors retry |
bors bot
added a commit
that referenced
this pull request
Feb 1, 2021
57: Add github actions CI r=eldruin a=ryankurte Replaces #56, just adding the actions executor without swapping bors or removing travis. Odds are this doesn't work but, seemingly one can't add actions to a repo from a branch so it has to be manually merged anyway and fixed in PRs... @posborne seem (un)reasonable? Co-authored-by: ryan <ryan@kurte.nz>
|
Timed out. |
|
bors retry |
bors bot
added a commit
that referenced
this pull request
Feb 1, 2021
57: Add github actions CI r=eldruin a=ryankurte Replaces #56, just adding the actions executor without swapping bors or removing travis. Odds are this doesn't work but, seemingly one can't add actions to a repo from a branch so it has to be manually merged anyway and fixed in PRs... @posborne seem (un)reasonable? Co-authored-by: ryan <ryan@kurte.nz>
|
Timed out. |
|
@ryankurte Since this works fine, could you also remove the |
|
bors try |
|
Finally! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #56, just adding the actions executor without swapping bors or removing travis.
Odds are this doesn't work but, seemingly one can't add actions to a repo from a branch so it has to be manually merged anyway and fixed in PRs...
@posborne seem (un)reasonable?