-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of embedded_hal::digital::IoPin #60
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nastevens (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
This has been updated to match the definition of IoPin as merged in embedded_hal PR 269. |
Hey folks, I've added a commit to remove the try_ prefixes so this can build against the embedded-hal HEAD. Would you rather merge it like this, or wait until embedded-hal pushes the next alpha release? |
Thanks! It would be better only to depend on released versions of |
@MorganR Could you update this PR now that I updated this repository to |
Absolutely, I'll update it by the end of the weekend |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thank you!
bors r+
@MorganR FYI this is published as part of the 0.4.0-alpha.1 release. |
This is just a draft, and is pending the PR merge of an IoPin implementation into embedded_hal.
I've verified it with a no-std DHT11 driver based on the IoPin PR.