Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added specified nightly toolchain support #109

Merged
merged 5 commits into from
Sep 1, 2022

Conversation

sprhawk
Copy link
Contributor

@sprhawk sprhawk commented Nov 16, 2021

  1. build-new-version.sh: added support to download specified nightly version
  2. fix cargo-bin-cross.inc and rust-bin-cross.inc to support nightly version
  3. added nightly 2019-07-08 version recipe ( optee requires specified nightly version )

Question: How can I specify a toolchain only to certain recipe? PREFERRED_VERSION only support selection of toolchain globally.

@nindoja
Copy link

nindoja commented Jan 19, 2022

Definitely interested in getting this pulled in since some nightly features would be great to have in a yocto recipe.

@sprhawk
Copy link
Contributor Author

sprhawk commented Jan 20, 2022

Definitely interested in getting this pulled in since some nightly features would be great to have in a yocto recipe.

you can try it by using my own repo

@posborne
Copy link
Member

With comments addressed, I think it is reasonable to include the script changes to support nightly and documentation in tree. To avoid having a consistently out of date nightly in tree, however, I think we should just set the expectation that if you want to use a nightly rust version in your layer that you'll need to generate the recipe using the script and maintain the generated bit outside of this tree. Most likely systems using a nightly compiler will be bumping versions regularly until required features are stable anyhow.

@sprhawk
Copy link
Contributor Author

sprhawk commented Feb 2, 2022

Agree, I just want to use that nightly version as an example there. I will remove then.

Signed-off-by: Yang Hongbo <yanghongbo@iotpi.io>
Signed-off-by: Yang Hongbo <yanghongbo@iotpi.io>
Signed-off-by: Yang Hongbo <yanghongbo@iotpi.io>
@nindoja
Copy link

nindoja commented Mar 21, 2022

@posborne any updates on getting this merged in?

Copy link
Member

@posborne posborne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the long delay and thanks for making these update to the script @sprhawk

@posborne posborne merged commit 703fd52 into rust-embedded:master Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants